Repository navigation
feat(cli): Authenticate headless installs with setup codes - #1873
Draft
evanpurkhiser wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
evanpurkhiser
changed the base branch from
main
to
git/feat-cli-bootstrap-account-credentials-from-setup-codes
November 3, 2026 18:44
This was referenced Nov 3, 2026
evanpurkhiser
force-pushed
the
git/feat-cli-authenticate-headless-installs-with-setup-codes
branch
from
November 3, 2026 18:53
077228e to
fa0808c
Compare
evanpurkhiser
changed the base branch from
git/feat-cli-bootstrap-account-credentials-from-setup-codes
to
git/feat-cli-add-headless-authentication-bootstrap-command
November 3, 2026 18:53
evanpurkhiser
force-pushed
the
git/feat-cli-authenticate-headless-installs-with-setup-codes
branch
from
November 3, 2026 19:10
fa0808c to
99eafe3
Compare
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
| import { runInteractiveLogin } from "../../lib/interactive-login.js"; | ||
| import { interactivePromptsAllowed } from "../../lib/interactive-prompts.js"; | ||
| import { logger } from "../../lib/logger.js"; | ||
| import { bootstrapAuthentication } from "../../lib/setup-code.js"; |
There was a problem hiding this comment.
A retained setup code makes later upgrades fail
If SENTRY_SETUP_CODE remains in the environment after installation, later cli setup or upgrade runs inherit it and try to redeem it again; because credentials are already stored, setup throws and the upgrade reports failure. Skip redemption when already authenticated or limit it to fresh installs.
Evidence
setup.tscallsbootstrapAuthentication()wheneverSENTRY_SETUP_CODEis set, before running configuration steps; setup exposes no--forceflag.bootstrapAuthentication()throws when stored credentials exist andforceis false, before attempting code redemption.- The upgrade path spawns
cli setupwith the inherited environment (process.envis copied when an install directory is set); a nonzero setup exit becomes anUpgradeError. - The setup test covers first-time redemption, but not a subsequent setup or upgrade with the same environment value.
Identified by Warden · code-review · Y2M-JUX
| import { runInteractiveLogin } from "../../lib/interactive-login.js"; | ||
| import { interactivePromptsAllowed } from "../../lib/interactive-prompts.js"; | ||
| import { logger } from "../../lib/logger.js"; | ||
| import { bootstrapAuthentication } from "../../lib/setup-code.js"; |
There was a problem hiding this comment.
Setup-code login never warms org/completion caches
Redeeming SENTRY_SETUP_CODE stores credentials but never calls warmCachesAfterLogin, and the later warmAttributeCompletions no-ops with an empty org-region cache, unlike the interactive fresh-install login path.
Evidence
- After setup-code auth succeeds, setup only
emits success; it does not callwarmCachesAfterLogin(). Boolean(getEnv().SENTRY_SETUP_CODE)then returns before the interactive login branch that would callwarmCachesAfterLogin().- The later
warmAttributeCompletions()usespickWarmupOrgs()→getAllOrgRegions(), which is empty untillistOrganizationsUncached()runs; with no orgs it returns immediately. completion-warmup.tsdocuments that fresh-install login is supposed to warm orgs then attribute keys viawarmCachesAfterLogin.
Identified by Warden · code-review · V4K-GBQ
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #1872. Let headless installs authenticate immediately when
SENTRY_SETUP_CODEis supplied. The installer hands authentication to the same bootstrap implementation used by an existing CLI and propagates failures.https://linear.app/getsentry/issue/VDY-338
Validation on the complete stack: typing, lint, and focused authentication/setup tests pass. The full test run has 21 unrelated failures reproduced on unchanged upstream main in the installer musl-detection, time-range, and zip-writer suites.
Native GitHub Stack: #1874, ordered #1870 → #1871 → #1872 → #1873.
Native bootstrap and shell installation passed against local OAuth redemption using internally generated codes. The shell test used a local artifact mirror for the unreleased binary.