Skip to content

docs: document frontend toolchain checks - #176

Open
addielaruee wants to merge 1 commit into
getsotto:mainfrom
addielaruee:docs/174-frontend-toolchain
Open

docs: document frontend toolchain checks#176
addielaruee wants to merge 1 commit into
getsotto:mainfrom
addielaruee:docs/174-frontend-toolchain

Conversation

@addielaruee

Copy link
Copy Markdown

Summary

  • document Node.js and wasm-pack versions used by the frontend CI job
  • add the binding-generation and typecheck sequence
  • link server and browser-regression prerequisites without duplicating their runbooks

Checks

  • npm ci --prefix web (Node 22)
  • verified documented commands and versions against web/package.json and .github/workflows/ci.yml
  • verified local documentation link targets

Closes #174

Signed-off-by: addielarue <bhasmerutika@gmail.com>

@Maxerns Maxerns left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @addielaruee - this is well done: versions and command order match CI, the dev/build/smoke descriptions are accurate, and the internal links check out.

One fix needed: the wasm-pack installation link (github.com/wasm-tool/wasm-pack) 404s. I think you meant the official rustwasm/wasm-pack repo. Could you correct it? And since CI pins 0.15.0 while the installer fetches latest, please add a short note to confirm the installed version with wasm-pack --version.

Once that's in, this is good to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CONTRIBUTING: document the frontend toolchain and local checks

2 participants