Skip to content

docs: add pull request template - #211

Open
LouisDeconinck wants to merge 1 commit into
getsotto:mainfrom
LouisDeconinck:docs/pr-template-142
Open

docs: add pull request template#211
LouisDeconinck wants to merge 1 commit into
getsotto:mainfrom
LouisDeconinck:docs/pr-template-142

Conversation

@LouisDeconinck

Copy link
Copy Markdown
Contributor

Summary

Add a short pull request template covering the summary, linked issue, tests, and DCO sign-off.

Checks

  • git diff --check

Closes #142

@github-actions

Copy link
Copy Markdown

Thanks for your first pull request to Sotto, and welcome.

Two things that trip up newcomers:

  • Every commit needs a Signed-off-by line under the Developer Certificate of Origin - PRs with unsigned commits cannot be merged. Sign off with git commit -s; if your branch already has unsigned commits, run git rebase --signoff main and push again.
  • Please run cargo fmt --all --check and cargo clippy --workspace --all-targets -- -D warnings before pushing, and add tests for new behaviour (cargo test --workspace runs the suite).

The full guide is in CONTRIBUTING.md - a maintainer will review shortly.

Signed-off-by: Louis Deconinck <louis.dck@gmail.com>
@Maxerns

Maxerns commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator

Thanks for these contributions! CI is now green on #210#214, but the branches are behind main, which blocks merging under our repository rules.
Could you enable “Allow edits from maintainers” in the right-hand sidebar on each PR? It may appear as “Allow edits and access to secrets by maintainers.” That would let me update the branches and handle the remaining merge steps.
If you’d prefer to keep that disabled, updating each PR branch with the latest getsotto/sotto main works too. @LouisDeconinck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a pull-request template that reminds contributors to sign off (DCO)

2 participants