fix: accept UTF-8 BOM in dotenv files - #214
Open
LouisDeconinck wants to merge 1 commit into
Open
Conversation
|
Thanks for your first pull request to Sotto, and welcome. Two things that trip up newcomers:
The full guide is in CONTRIBUTING.md - a maintainer will review shortly. |
8 tasks
Maxerns
approved these changes
Sep 11, 2026
Maxerns
left a comment
Collaborator
There was a problem hiding this comment.
Since you've been on a roll: I opened #216 for the greeter posting "first PR" greetings on every PR from returning contributors (you've received a few yourself). It's a small Actions/J
avaScript task with a defined policy feel free to pick it up if it interests you.
Signed-off-by: Louis Deconinck <louis.dck@gmail.com>
LouisDeconinck
force-pushed
the
fix/dotenv-bom-203
branch
from
September 11, 2026 11:04
26da64f to
45b0ef6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ignore one optional leading UTF-8 BOM when parsing
.envinput, while preserving BOM characters inside values and adding LF/CRLF regression coverage.Checks
git diff --checkcargo test -p sotto-cli dotenvandcargo fmt --all --checkcould not run locally because Cargo is not installedCloses #203