fix: prefix result bad semver#971
Open
didierm-perso wants to merge 2 commits intogetwud:mainfrom
Open
Conversation
|
🤔 Not dug into the full detail of this area of the code... but isn't the problem more that this regex isn't expecting literal Also... is there no testing around this area? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #970
This PR is not prefect but the regexp now checks if we have at least x.y.z to start the 2nd group. This group will be used for the semver compare.
This will work with tag like amd64-1.2.3 but not with tag like amd64-1 or amd64-1.2 (those tags should use digest and not semver) If we want to keep amd64-1 or amd64-1.2 we'll need to use the include tags.
Fix PR #839