Skip to content

Wait for image delivery before checking Memory draft state (GET-298) - #499

Merged
kubbot merged 1 commit into
mainfrom
codex/get-298-durable-queue-test
Oct 30, 2026
Merged

kubbot merged 1 commit into
mainfrom
codex/get-298-durable-queue-test

Conversation

@kubbot

@kubbot kubbot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

The Memory draft target test could inspect the request before the durable image outbox finished reading its bytes. CI then failed with an undefined POST even though the newer text and selected person remained intact.

Hold and release the storage read explicitly, verify no request is sent while it is pending, then wait for exactly one real queue POST. Keep the existing payload, draft and selected-person assertions.

Validation: the controlled pending-read counterexample failed at the expected early-POST assertion; all 5 tests in the real-component file now pass. Independent review found no outstanding P0/P1. This PR changes one test file; production code is unchanged.

Related: GET-298. The broader live acceptance remains In Progress.

Latest-head gates: CI 41026761894 and Security 41026761767 passed, including the full Web lint/typecheck/test/build and required aggregates. Effective main rules require CI required and Security required with strict up-to-date checks. The optional Vercel Web preview reports a platform deployment rate limit; that failure is retained and no quota/configuration override was attempted. This single-test-file change needs no resident runtime activation.

@vercel

vercel Bot commented Oct 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
talent-signal Skipped Skipped Oct 30, 2026 8:29am UTC

@ecc-tools

ecc-tools Bot commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

ECC Tools / Security Evidence

Commit: 31a7141cbc3c1873a3b2c120593930fe2a0c5b18

Security evidence gate passed (success)

No security-sensitive scanner-evidence gap detected.

Mode: enforce

Scanned 1 changed file(s). No missing scanner-evidence signal was detected.

Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission.

@vercel

vercel Bot commented Oct 30, 2026

Copy link
Copy Markdown

Deployment failed for project talent-signal-web with the following error:

Resource is limited - try again in 24 hours (more than 100, code: "api-deployments-free-per-day").

Learn More: https://vercel.com/3293172751nss-1526s-projects?upgradeToPro=build-rate-limit

@ecc-tools

ecc-tools Bot commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

ECC Tools / PR Risk Taxonomy

Commit: 31a7141cbc3c1873a3b2c120593930fe2a0c5b18

PR taxonomy review recommended (neutral)

Detected 1 PR taxonomy bucket(s): CI/CD Recommendation.

Scanned 1 changed file(s).

Roadmap taxonomy buckets:

CI/CD Recommendation

CI, dependency, coverage, and contract signals should be routed into follow-up checks or verification work.

Signals:

  • User-facing UI changes may ship without browser coverage
  • 1 CI or workflow path(s) changed

Paths:

  • apps/web/components/conversation/queued-conversation-memory-target.test.tsx

Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission.

@ecc-tools

ecc-tools Bot commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

ECC Tools / Reference Set Readiness

Commit: 31a7141cbc3c1873a3b2c120593930fe2a0c5b18

Reference set readiness gaps detected (neutral)

Reference evidence present for 0/7 areas (0%) across 1 changed file(s).

This check is based on files changed in this PR. Repository-level readiness is still reported by /ecc-tools analyze comments and generated manifests.

Area Status Evidence / Next Step
Deep analyzer corpus Missing Add analyzer fixture, golden, benchmark, or reference-set files that can catch analyzer regressions.
RAG/evaluator comparison Missing Add retrieval or evaluator reference-set comparison fixtures with expected ranking behavior.
PR salvage/review corpus Missing Add stale-PR, review-thread, reopen-flow, or salvage reference cases for queue cleanup automation.
Discussion triage corpus Missing Add public discussion triage fixtures, golden cases, or reference sets for informational, answered, and no-response classifications.
Harness compatibility Missing Add cross-harness, adapter-compliance, or harness-audit evidence for Claude, Codex, OpenCode, Zed, dmux, and agent surfaces.
Security evidence Missing Attach security evidence such as SBOMs, SARIF, audit reports, or AgentShield evidence packs.
CI failure-mode evidence Missing Add captured CI failure logs, dry-run fixtures, or troubleshooting docs for common workflow failure modes.

Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission.

@ecc-tools

ecc-tools Bot commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

ECC Tools / Hosted Promotion Readiness

Commit: 31a7141cbc3c1873a3b2c120593930fe2a0c5b18

Hosted promotion readiness passed (success)

No hosted promotion evidence gaps detected across 1 changed file(s); 0 corpus scenarios had matching evidence.

This check compares PR file changes against the evaluator/RAG promotion corpus in src/analyzers/fixtures/evaluator-rag-corpus.ts.
Hosted output scoring inspected 0 completed cached hosted job results.

No evaluator corpus scenarios matched this PR.

Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission.

@github-actions github-actions Bot added the area:web Web application label Oct 30, 2026
@kubbot
kubbot merged commit 59c2d2e into main Oct 30, 2026
24 of 25 checks passed
@kubbot
kubbot deleted the codex/get-298-durable-queue-test branch October 30, 2026 08:42

This branch was previously deployed

1 inactive deployment
Preview – talent-signal — 31a7141c Deployed Oct 30, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:web Web application

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant