Skip to content

fix(validate): honor effective env cascade - #524

Merged
gfargo merged 1 commit into
mainfrom
fix/validate-effective-env-cascade
Aug 27, 2026
Merged

fix(validate): honor effective env cascade#524
gfargo merged 1 commit into
mainfrom
fix/validate-effective-env-cascade

Conversation

@gfargo

@gfargo gfargo commented Aug 27, 2026

Copy link
Copy Markdown
Owner

Summary

Advance #248 by making strut <stack> validate evaluate required_vars against the same effective environment cascade used by deployment.

Changes

  • replace the required-vars helper's base-file-only reload with validate_env_file
  • include common.env, the selected stack/project base env, the active topology host layer, and generated stack/host layers in normal last-wins precedence
  • preserve the existing missing-env warning, helper signature, diagnostics, counters, and command exit behavior
  • retain the previous tolerance for loader failures under set -e

Validation

  • bats tests/test_validate.bats tests/test_utils.bats tests/test_env_gen_layer.bats tests/test_topology.bats tests/test_cli_resolve.bats </dev/null — 178 passed
  • bats tests/ </dev/null — 2,650 passed, 2 expected skips
  • shellcheck -x -S warning lib/cmd_validate.sh
  • bash -n lib/cmd_validate.sh
  • git diff --check
  • semantic review approved with no actionable findings

Advances #248.

@gfargo
gfargo merged commit 95826a9 into main Aug 27, 2026
3 checks passed
@gfargo
gfargo deleted the fix/validate-effective-env-cascade branch August 27, 2026 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant