Skip to content

Re-vendor WebGPU#9090

Merged
Wumpf merged 3 commits intogfx-rs:trunkfrom
evilpie:vendor
Apr 12, 2026
Merged

Re-vendor WebGPU#9090
Wumpf merged 3 commits intogfx-rs:trunkfrom
evilpie:vendor

Conversation

@evilpie
Copy link
Copy Markdown
Contributor

@evilpie evilpie commented Feb 21, 2026 •
edited
Loading

Connections

Description

This updates the WebGPU binding from wasm-bindgen/web-sys to the latest version. I had to modify the vendor script, because it can now reference other kind of ExternalResources, in particular the still unstable VideoFrame.

Testing
Explain how this change is tested.

Squash or Rebase?

Rebase

Checklist

  • Run cargo fmt.
  • Run taplo format.
  • Run cargo clippy --tests. If applicable, add:
    • --target wasm32-unknown-unknown
  • Run cargo xtask test to run tests.
  • If this contains user-facing changes, add a CHANGELOG.md entry.

@evilpie

This comment was marked as outdated.

Sign in to view
@evilpie evilpie changed the title Upadate wasm-bindgen Upadate wasm-bindgen and re-vendor WebGPU Feb 21, 2026
@evilpie

This comment was marked as outdated.

Sign in to view
@ErichDonGubler ErichDonGubler changed the title Upadate wasm-bindgen and re-vendor WebGPU Update wasm-bindgen and re-vendor WebGPU Feb 23, 2026
@andyleiserson andyleiserson mentioned this pull request Feb 24, 2026
Merged
@evilpie evilpie force-pushed the vendor branch 2 times, most recently from 3e1d8f6 to 0d45ff2 Compare March 6, 2026 10:30
@evilpie evilpie changed the title Update wasm-bindgen and re-vendor WebGPU Re-vendor WebGPU Mar 6, 2026
@evilpie evilpie mentioned this pull request Mar 6, 2026
Merged
6 tasks
@evilpie evilpie marked this pull request as ready for review March 6, 2026 10:38
@evilpie evilpie marked this pull request as draft March 6, 2026 10:46
@evilpie evilpie marked this pull request as ready for review March 6, 2026 11:02
@evilpie evilpie marked this pull request as draft March 6, 2026 19:18
@evilpie evilpie marked this pull request as ready for review March 6, 2026 19:18
@evilpie evilpie marked this pull request as draft March 7, 2026 06:54
@evilpie
Copy link
Copy Markdown
Contributor Author

evilpie commented Mar 7, 2026

Might as well wait for VideoFrame to become stable.

@cwfitzgerald
Copy link
Copy Markdown
Member

cwfitzgerald commented Mar 7, 2026 •
edited
Loading

That may that months or years, so id prefer us to also vendor video frame for the compiler, but not expose it.

@evilpie
Copy link
Copy Markdown
Contributor Author

evilpie commented Mar 7, 2026

VideoFrame would be in the next release. wasm-bindgen/wasm-bindgen#5008

@cwfitzgerald
Copy link
Copy Markdown
Member

cwfitzgerald commented Mar 7, 2026

Oh nice, alright!

evilpie
evilpie commented Mar 27, 2026
View reviewed changes
Comment thread wgpu-hal/src/gles/queue.rs
@evilpie evilpie marked this pull request as ready for review March 28, 2026 13:49
Wumpf
Wumpf requested changes Apr 11, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, a lot of backend/webgpu looks a lot better with this now! However, you got a questionable leftover (?) todo there, I trust you did try out WebGPU?

Comment thread wgpu/src/backend/webgpu.rs Outdated
Comment thread wgpu/src/backend/webgpu.rs Outdated
Comment thread wgpu/src/backend/webgpu.rs
Comment on lines +2380 to +2382
wasm_bindgen::JsValue::from(map_texture_format(*format))
.dyn_into::<js_sys::JsString>()
.unwrap()
Copy link
Copy Markdown
Member

@Wumpf Wumpf Apr 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[not actionable] very annoying unwraps, but can't see away around them either, seems like a general problem with websys enums :/

Copy link
Copy Markdown
Contributor Author

@evilpie evilpie Apr 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed.

@evilpie evilpie force-pushed the vendor branch 3 times, most recently from 09ebbdb to d43e3f0 Compare April 12, 2026 15:34
@evilpie evilpie force-pushed the vendor branch 2 times, most recently from d3174d3 to 5bef7ee Compare April 12, 2026 15:50
@evilpie
Copy link
Copy Markdown
Contributor Author

evilpie commented Apr 12, 2026

So, finally got this green (hopefully).

Wumpf
Wumpf approved these changes Apr 12, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks all good to me now! Also gave it a spin locally as well just for good measure, seems fine :)
Thanks for all the work!

@Wumpf Wumpf merged commit 7143bbe into gfx-rs:trunk Apr 12, 2026
59 checks passed
@evilpie

This comment was marked as outdated.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cwfitzgerald cwfitzgerald cwfitzgerald left review comments

@Wumpf Wumpf Wumpf approved these changes

+1 more reviewer

@inner-daemons inner-daemons inner-daemons left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@Wumpf Wumpf

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@evilpie @cwfitzgerald @Wumpf @inner-daemons