Skip to content

Conversation

@ericbsd
Copy link
Member

@ericbsd ericbsd commented Nov 14, 2025

It did move from runtime to its own packages.

See ghostbsd/ghostbsd-src@32b6de9 for more details

Summary by Sourcery

Separate zlib into its own packages and include them in the base package list

Enhancements:

  • Add libz (zlib) package to base packaging
  • Add libz-devel (zlib headers) package to base packaging

It did move from runtime to its own packages.

See ghostbsd/ghostbsd-src@32b6de9 for more details
@ericbsd ericbsd requested review from a team as code owners November 14, 2025 22:53
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Nov 14, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR refactors zlib packaging by extracting it from the runtime package into standalone 32- and 64-bit libz packages and updating the base package manifest to consume these new subpackages.

File-Level Changes

Change Details Files
Extracted zlib into dedicated libz subpackages
  • Added new package definitions for 32-bit and 64-bit zlib
  • Created Makefile and metadata for each libz variant
  • Configured pkg-plist to include zlib files
packages/lib32-zlib
packages/lib64-zlib
Updated base package to depend on new libz packages
  • Removed zlib entries from the runtime section
  • Added lib32-zlib and lib64-zlib to base dependencies
  • Adjusted version and dependency lists in packages/base
packages/base

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ericbsd ericbsd merged commit 95a19d3 into master Nov 14, 2025
3 checks passed
@ericbsd ericbsd deleted the libz-missing branch November 14, 2025 22:54
@github-project-automation github-project-automation bot moved this from In Review to Done in Development Tracker Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants