Skip to content

Conversation

@ericbsd
Copy link
Member

@ericbsd ericbsd commented Oct 14, 2025

  • Add detect_x_server() function to identify XLibre vs Xorg
  • Automatically prefix NVIDIA driver packages with 'xlibre-' when XLibre is detected
  • Maintain backward compatibility with standard Xorg packages
  • Enhanced error reporting to include both nvidia and xlibre package searches

Summary by Sourcery

Detect XLibre versus Xorg servers and adjust NVIDIA driver package names accordingly while preserving compatibility and enhancing error reporting

New Features:

  • Introduce detect_x_server function to distinguish between XLibre and Xorg
  • Automatically prefix NVIDIA driver packages with "xlibre-" when XLibre is detected

Enhancements:

  • Maintain backward compatibility with standard Xorg NVIDIA packages
  • Improve error reporting to include searches for both NVIDIA and xlibre driver packages

- Add detect_x_server() function to identify XLibre vs Xorg
- Automatically prefix NVIDIA driver packages with 'xlibre-' when XLibre is detected
- Maintain backward compatibility with standard Xorg packages
- Enhanced error reporting to include both nvidia and xlibre package searches
@ericbsd ericbsd requested review from a team as code owners October 14, 2025 21:52
@sourcery-ai
Copy link

sourcery-ai bot commented Oct 14, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Introduces XLibre server detection in xconfig and adjusts NVIDIA driver package resolution to support both XLibre-prefixed and standard Xorg naming, with improved fallback logic and error messages.

File-Level Changes

Change Details Files
Add X server type detection
  • Introduce detect_x_server() to distinguish XLibre vs Xorg
  • Invoke detect_x_server() early and store the result in a variable
bin/xconfig
Prefix NVIDIA driver packages for XLibre
  • When XLibre is detected, automatically prepend 'xlibre-' to NVIDIA package names
  • Adjust driver installation logic to use the prefixed names
bin/xconfig
Maintain standard Xorg package fallback
  • If prefixed NVIDIA packages are unavailable, fall back to standard names
  • Ensure existing Xorg workflows remain unaffected by new logic
bin/xconfig
Enhance error reporting for driver resolution
  • Report both prefixed and standard package names on search failure
  • Provide clear messaging about which driver names were attempted
bin/xconfig

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ericbsd ericbsd merged commit a907232 into master Oct 14, 2025
2 checks passed
@ericbsd ericbsd deleted the fix-xlibre branch October 14, 2025 21:53
@github-project-automation github-project-automation bot moved this from In Review to Done in Development Tracker Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants