Skip to content

Conversation

@ericbsd
Copy link
Member

@ericbsd ericbsd commented Jan 26, 2026

  • Removed calls to enable_rc_conf and start_service_safe for vboxguest and vboxservice within setup_virtualbox.

Not supported with Xlibre at this moment.

Summary by Sourcery

Enhancements:

  • Stop enabling and starting vboxguest and vboxservice automatically in setup_virtualbox to reflect current Xlibre support.

- Removed calls to `enable_rc_conf` and `start_service_safe` for `vboxguest` and `vboxservice` within `setup_virtualbox`.

Not supported with Xlibre at this moment.
@ericbsd ericbsd requested review from a team as code owners January 26, 2026 02:36
@ghostbsd-bot ghostbsd-bot moved this to In Review in Development Tracker Jan 26, 2026
@ericbsd ericbsd merged commit 9d4fa14 into master Jan 26, 2026
1 check passed
@ericbsd ericbsd deleted the vbox-cleanup branch January 26, 2026 02:38
@sourcery-ai
Copy link

sourcery-ai bot commented Jan 26, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR updates the xconfig setup_virtualbox logic to stop managing VirtualBox guest services via rc.conf/service automation, aligning behavior with current Xlibre support constraints.

File-Level Changes

Change Details Files
Stop enabling and starting VirtualBox guest services from setup_virtualbox
  • Remove calls that enable vboxguest and vboxservice in rc.conf
  • Remove calls that start vboxguest and vboxservice services during setup
  • Ensure setup_virtualbox no longer assumes presence or support of VirtualBox service management under Xlibre
bin/xconfig

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ericbsd ericbsd moved this from In Review to Done in Development Tracker Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants