Repository navigation
fix(i18n): highlight the detected language before the first pick - #15
Merged
Merged
Conversation
The bootstrap (detectLanguage in index) maps the device locale to an app language — including the zh vs zh-TW script split — but the settings selector read only the stored preference, so on a fresh install nothing was highlighted until the user picked a language. The selector now falls back to i18n.language — what is actually being rendered — so the highlighted pill and the rendered language can never disagree.
💯 Test Coverage
😎 Tests Results
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bootstrap (detectLanguage in index) maps the device locale to an app language — including the zh vs zh-TW script split — but the settings selector read only the stored preference, so on a fresh install nothing was highlighted until the user picked a language. The selector now falls back to i18n.language — what is actually being rendered — so the highlighted pill and the rendered language can never disagree.