feat(gen/circleci): add --skip-ats to opt out of ATS chart tests - #2097
Open
mcharriere wants to merge 3 commits into
Open
feat(gen/circleci): add --skip-ats to opt out of ATS chart tests#2097mcharriere wants to merge 3 commits into
mcharriere wants to merge 3 commits into
Conversation
By default an app-flavour repo runs architect/run-tests-with-ats between build-chart and the chart push, and generation emits tests/ats/Pipfile. --skip-ats suppresses those test jobs and the Pipfile; the chart push then gates directly on build-chart.
mcharriere
changed the title
piontec
reviewed
Jul 27, 2026
piontec
left a comment
piontec
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Do you also have the part that has to go to github/github?
piontec
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a
--skip-atsopt-out flag todevctl gen circleci.By default an
app-flavour repo runsarchitect/run-tests-with-atsbetweenbuild-chartand the chart push, and generation emits the canonicaltests/ats/Pipfile.--skip-atsopts out:run-tests-with-atsjobs (execute-chart-tests/execute-chart-tests-release) from.circleci/workflows.yml.requirestobuild-chartdirectly, keeping the dependency graph valid.tests/ats/Pipfile(ATSInputs()returns nil).Only applies to the app flavour. Follows the existing
--branch-publishopt-in wiring end to end (flag ->circleci.Config->params.Params-> template).Notes
Template edits are whitespace-neutral for the default (
SkipATS=false), so existing golden tests pass unchanged. AddedTest_SkipATSOmitsChartTests; package tests andgo vetare green.