fix(workflows): stop gitsemver install from building double-v prefix - #244
Merged
Conversation
…d URL
Renovate fills the install-binary-action `version:` field with the
v-prefixed release tag (e.g. `v2.0.1`), but the gitsemver `download_url`
template hardcoded another `v` (`v${version}`). The two combined into
`.../download/vv2.0.1/gitsemver-vv2.0.1-linux-amd64.tar.gz`, which 404s
and breaks the Create Release workflow for every consumer.
Make the template consume the `v` from `${version}` (matching the
neighbouring architect install block) and keep the value `v`-prefixed, so
it resolves correctly and survives future Renovate bumps. This supersedes
the temporary fix in eaec78f, which set the value bare and would re-break
on the next Renovate bump.
Refs giantswarm/giantswarm#37171
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Łukasz Piątkowski <piontec@gmail.com>
stone-z
reviewed
Jul 15, 2026
stone-z
approved these changes
Jul 15, 2026
stone-z
left a comment
stone-z
left a comment
Contributor
There was a problem hiding this comment.
Suggest shortening claude's changelog, but otherwise 👍
Co-authored-by: Zach Stone <zach@giantswarm.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renovate fills the install-binary-action
version:field with the v-prefixed release tag (e.g.v2.0.1), but the gitsemverdownload_urltemplate hardcoded anotherv(v${version}). The two combined into.../download/vv2.0.1/gitsemver-vv2.0.1-linux-amd64.tar.gz, which 404s and breaks the Create Release workflow for every consumer.Make the template consume the
vfrom${version}(matching the neighbouring architect install block) and keep the valuev-prefixed, so it resolves correctly and survives future Renovate bumps. This supersedes the temporary fix in eaec78f, which set the value bare and would re-break on the next Renovate bump.Refs giantswarm/giantswarm#37171
Checklist