fix: point example simple-db-app ImageRepository at gsoci registry - #144
Merged
Conversation
Replace decommissioned giantswarmpublic.azurecr.io/giantswarm-catalog with gsoci.azurecr.io/charts/giantswarm in the simple-db-app example ImageRepository across bases, docs, and tests/ats fixtures, matching the sibling hello-world example. Part of giantswarm/giantswarm#35783
|
Semantic YAML source diff — key reordering without value changes is ignored. Output@@ bases/environments/stages/dev/hello_app_cluster/imagerepositories.yaml @@
/spec/image (image.toolkit.fluxcd.io/v1beta2/ImageRepository/org-${organization}/${cluster_name}-simple-db-app)
± value change
- giantswarmpublic.azurecr.io/giantswarm-catalog/simple-db-app
+ gsoci.azurecr.io/charts/giantswarm/simple-db-app
@@ bases/environments/stages/staging/hello_app_cluster/imagerepositories.yaml @@
/spec/image (image.toolkit.fluxcd.io/v1beta2/ImageRepository/org-${organization}/${cluster_name}-simple-db-app)
± value change
- giantswarmpublic.azurecr.io/giantswarm-catalog/simple-db-app
+ gsoci.azurecr.io/charts/giantswarm/simple-db-app
@@ tests/ats/assertions/exists/organizations/workload-clusters/hello-app-dev-1/imagerepositories.yaml @@
/spec/image (image.toolkit.fluxcd.io/v1beta2/ImageRepository/org-org-name/hello-app-dev-1-simple-db-app)
± value change
- giantswarmpublic.azurecr.io/giantswarm-catalog/simple-db-app
+ gsoci.azurecr.io/charts/giantswarm/simple-db-app
@@ tests/ats/assertions/exists/organizations/workload-clusters/hello-app-staging-1/imagerepositories.yaml @@
/spec/image (image.toolkit.fluxcd.io/v1beta2/ImageRepository/org-org-name/hello-app-staging-1-simple-db-app)
± value change
- giantswarmpublic.azurecr.io/giantswarm-catalog/simple-db-app
+ gsoci.azurecr.io/charts/giantswarm/simple-db-app
Suppress with |
Validation output log |
Rendered manifest diff output log |
uvegla
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The example
simple-db-appImageRepositoryreferenced the decommissionedgiantswarmpublic.azurecr.io/giantswarm-catalog/simple-db-appregistry. This updates it to the currentgsoci.azurecr.io/charts/giantswarm/simple-db-app, consistent with the siblinghello-worldexample in the same template and with the app'scatalog: giantswarm(which lives atgsoci.azurecr.io/charts/giantswarm/).Files changed (all 5 occurrences):
bases/environments/stages/dev/hello_app_cluster/imagerepositories.yamlbases/environments/stages/staging/hello_app_cluster/imagerepositories.yamltests/ats/assertions/exists/organizations/workload-clusters/hello-app-dev-1/imagerepositories.yamltests/ats/assertions/exists/organizations/workload-clusters/hello-app-staging-1/imagerepositories.yamldocs/add_wc_environments.mdWhy
giantswarmpublic.azurecr.iois decommissioned, so a FluxImageRepositorypointing at it silently fails to scan tags. Fixing the template stops new clusters from copying the stale registry.Part of giantswarm/giantswarm#35783.
Notes
simple-db-appis fictional tutorial-only content (not published to any registry), so this aligns the registry name with the rest of the template; it does not make the example resolve a real chart (pre-existing, out of scope).tests/atsexists-assertion fixture are updated together so the ATS e2e stays green.