packages-to-build: fix possible unbreakable cycle in dependency graph#80
Open
yoniyes wants to merge 1 commit intogiltayar:mainfrom
Open
packages-to-build: fix possible unbreakable cycle in dependency graph#80yoniyes wants to merge 1 commit intogiltayar:mainfrom
yoniyes wants to merge 1 commit intogiltayar:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
biltassumes that cycles represented as['A', 'B', 'C']are the simple case ofA-->B-->C-->A(cyclic) and tried to break the cycle by always removing the edge betweenAandC. However,['A', 'B', 'C']can also be the case forA-->B-->C-->B-->A, and in this case, the edge betweenCandAdoesn’t exist. This enables the following loop:In short, the cycle found was assumed to represent a false connectivity between the edges, causing the cycle to never be broken.
This change is