read/elf: Exclude ARM mapping symbols from is_definition()#599
Closed
pcc wants to merge 1 commit intogimli-rs:masterfrom
Closed
read/elf: Exclude ARM mapping symbols from is_definition()#599pcc wants to merge 1 commit intogimli-rs:masterfrom
pcc wants to merge 1 commit intogimli-rs:masterfrom
Conversation
Contributor
|
I agree this needs fixing, but I don't think we want to fix it with special case logic like this. There's some previous discussion in #447, but I haven't gotten back to it yet to decide what to do. |
Contributor
Author
|
I think most other tools just hardcode the exclusion for mapping symbols though, e.g. LLVM: https://github.com/llvm/llvm-project/blob/6b3470b4b83195aeeda60b101e8d3bf8800c321c/llvm/include/llvm/Object/ELFObjectFile.h#L742 It seems like the simplest approach and I think this is appropriate; mapping symbols are a bit of a hack (fortunately well defined by the various ABIs) and need to be countered with hacks in the consuming programs. |
Contributor
|
See the last commit of #601 for an alternative fix for this. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.