Repository navigation
refactor: delete unwired ASRSegmentModel + StreamingTextReconciler (QUA-263/QUA-265) - #45
Merged
Merged
Conversation
…UA-263/QUA-265) Both sat unwired since landing, with zero production evidence for their differentiators (nonstream_result=true: 0 of 2935 streamed results; pauseBoundary: no consumer). Deleted per ponytail-audit follow-up: - Inline the shrink-rescue heuristic (the one live piece, formerly ASRHypothesis.looksLikeNewUtterance) into DoubaoResultState.ingest. - Trim ASRPipelineIntegrationTests to the two live final-path tests (formatter -> corrector); the five cold-layer tests leave with the code. - Rewrite ARCHITECTURE.md §7: removal record, resurrection triggers, and the domain decisions worth not re-deriving. Net -961 lines. swift test: 322 tests, 0 failures. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deletes the two "reserved, not-yet-wired" design assets kept under ARCHITECTURE.md §7. Both sat unwired since landing, with zero production evidence for their differentiators (
nonstream_result=true: 0 of 2935 streamed results across two log files;pauseBoundary: no consumer). Net -961 lines.ASRSegmentModel.swift(248),StreamingTextReconciler.swift(114) and their test suites (431).ASRHypothesis.looksLikeNewUtteranceshared with the shipping rescue path — directly intoDoubaoResultState.ingest. Behavior unchanged.ASRPipelineIntegrationTeststo the two live final-path tests (formatter → corrector, ashandleFinalcomposes them); the five cold-layer tests leave with the code.Resurrection path: git history, or rewrite against the §7 notes.
Test plan
swift test: 322 tests, 0 failures.make install/ real-device pass needed.🤖 Generated with Claude Code