Skip to content

refactor: delete unwired ASRSegmentModel + StreamingTextReconciler (QUA-263/QUA-265) - #45

Merged
giraphant merged 1 commit into
mainfrom
giraphant/ponytail2
Jul 19, 2026
Merged

giraphant merged 1 commit into
mainfrom
giraphant/ponytail2

Conversation

@giraphant

Copy link
Copy Markdown
Owner

Summary

Deletes the two "reserved, not-yet-wired" design assets kept under ARCHITECTURE.md §7. Both sat unwired since landing, with zero production evidence for their differentiators (nonstream_result=true: 0 of 2935 streamed results across two log files; pauseBoundary: no consumer). Net -961 lines.

  • Delete ASRSegmentModel.swift (248), StreamingTextReconciler.swift (114) and their test suites (431).
  • Inline the shrink-rescue heuristic — the one live piece, formerly ASRHypothesis.looksLikeNewUtterance shared with the shipping rescue path — directly into DoubaoResultState.ingest. Behavior unchanged.
  • Trim ASRPipelineIntegrationTests to the two live final-path tests (formatter → corrector, as handleFinal composes them); the five cold-layer tests leave with the code.
  • Rewrite ARCHITECTURE.md §7 as a removal record: resurrection triggers (nonstream late revisions observed / third engine / pause-aware boundaries / incremental injection) and the domain decisions worth not re-deriving (empty-snapshot hold, grapheme ≠ backspace count, scalar-exact prefix matching, no sentence-max forced boundary, per-engine event mapping).

Resurrection path: git history, or rewrite against the §7 notes.

Test plan

  • swift test: 322 tests, 0 failures.
  • Pure logic + docs only — recording pipeline untouched, no make install / real-device pass needed.

🤖 Generated with Claude Code

…UA-263/QUA-265)

Both sat unwired since landing, with zero production evidence for their
differentiators (nonstream_result=true: 0 of 2935 streamed results;
pauseBoundary: no consumer). Deleted per ponytail-audit follow-up:

- Inline the shrink-rescue heuristic (the one live piece, formerly
  ASRHypothesis.looksLikeNewUtterance) into DoubaoResultState.ingest.
- Trim ASRPipelineIntegrationTests to the two live final-path tests
  (formatter -> corrector); the five cold-layer tests leave with the code.
- Rewrite ARCHITECTURE.md §7: removal record, resurrection triggers, and
  the domain decisions worth not re-deriving.

Net -961 lines. swift test: 322 tests, 0 failures.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@giraphant
giraphant merged commit 8b280e9 into main Jul 19, 2026
1 check passed
@giraphant
giraphant deleted the giraphant/ponytail2 branch July 26, 2026 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant