Repository navigation
build: disable code coverage in release builds; fail on codesign errors - #57
Merged
Merged
Conversation
The auto-generated package scheme turns on code coverage, and xcodebuild applies it to plain `build` too, so 0.4.5–0.5.0 shipped every module (MLX C++ core included) with profile counters and coverage maps: ~15 MB of the 42 MB executable. ENABLE_CODE_COVERAGE=NO gates both the Swift and clang flags; the executable drops to 27 MB and the DMG from 18.4 MB to ~12.1 MB. Also chain codesign and the success echo with `&&`, so a failed signature (e.g. a locked keychain) stops the build instead of printing "signed". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
make buildpassesENABLE_CODE_COVERAGE=NOto xcodebuild. The auto-generated package scheme enables coverage, and xcodebuild applies it to plain builds too. Every module in 0.4.5–0.5.0, including the MLX C++ core, shipped with__llvm_prf_*counters and an__LLVM_COVsegment (~15 MB).&&, so a signing failure (e.g. a locked keychain) fails the build instead of reporting success.Size
Verification
make dist: nollvm_prf/LLVM_COVsections; Developer ID signature verifies (--deep --strict); audio-input entitlement anddefault.metallibpresent.make buildexit 2 with no "signed" line.🤖 Generated with Claude Code