Jail LocalFetcher to a root directory and cap POM read size - #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LocalFetcher.walkfollows<parent><relativePath>and reads files from disk. It already rejects absolute paths and symlinks but does not bound../, so a hostile POM can read arbitrary files relative to the caller's working directory. This matters once the parser runs server-side against pushed repositories rather than a user's own checkout.NewLocalFetcherFrom,NewLocalFetcherandResolveLocalnow take anfsRootargument. The walk refuses to step outside it, and an emptyfsRootskips the walk entirely so callers handling untrusted bytes can opt out of filesystem access altogether. The containment check compares cleaned absolute paths with a trailing separator so/tmp/repo-evilis not treated as inside/tmp/repo.Separately,
ParsePOMnow rejects input overMaxPOMBytes(10 MB, tunable), andreadPOMFile,DirFetcher.FetchandHTTPFetcher.FetchBytesapply the same limit at read time so an oversized file or response is never fully buffered.This is a breaking change to the three
LocalFetcherconstructors. Known caller to update:manifests/internal/maven/maven.go:43.