Preserve package properties in CycloneDX output - #14
Merged
andrew merged 1 commit intoAug 27, 2026
Conversation
There was a problem hiding this comment.
Pull request overview
This PR ensures Package.Properties are preserved when encoding CycloneDX SBOMs, addressing the gap where properties were parsed/populated internally but dropped from generated CycloneDX output. This aligns the encoder with existing CycloneDX parsing support that already reads component properties back into Package.Properties.
Changes:
- Copy
Package.Propertiesinto CycloneDXcomponent.propertiesduring encoding. - Verify CycloneDX JSON preserves properties via a JSON round-trip regression test.
- Verify CycloneDX XML output includes
<properties><property .../></properties>via an encoding regression test.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| encode.go | Adds property propagation from Package.Properties into encoded CycloneDX components. |
| encode_test.go | Extends fixtures and tests to assert CycloneDX JSON round-trips properties and CycloneDX XML includes the expected <property> element. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs git-pkgs/git-pkgs#307
Summary
Package.Propertiesinto generated CycloneDX components.Motivation
Package.Propertiesis currently populated and parsed by the SBOM package, but generated CycloneDX documents omit it during encoding.This is a prerequisite for git-pkgs/git-pkgs#307, which attaches manifest occurrence metadata to SBOM components using indexed properties.
Verification
gofmtgo test ./... -count=1