feat(core,agents): FindingCategory extensible + agent distribution prep (s78) - #166
Merged
Conversation
…/37 green
Factories: createWaiver(), createScan(), createFix() with validation + invariants.
Fix type formalized (was inline { description: string }).
createScan computes AuditSummary from findings (AUDIT-G2 invariant).
Test builders: makeTestFinding, makeTestFix, makeTestWaiver, makeTestScan.
Exported from @gitgov/core/audit + @gitgov/core. Builders from audit/testing subpath.
3050/3050 core tests green, 0 regressions.
…ep (s78)
- FindingCategory: BaseFindingCategory | (string & {}) — AUDIT-E1..E4
- Prisma: enum → String for Finding.category column
- Semgrep CWE mapping fix: CWE-89/79/22/78/94/502 → security-vulnerability (SGP-C3)
- Agent packages: add gitgov.agent.categories field to all 4 agents
- security-audit: add semantic-release + plugins as devDeps (fix exit 127)
- CLI: add @gitgov/agent-security-audit as dependency (zero-friction bundling)
- http_llm_detector: refactor isValidCategory to isKnownCategory with BaseFindingCategory
workspace:* in dependencies would be published as literal string by npm publish (semantic-release). Move core to peerDependencies (for npm consumers) + devDependencies (for monorepo dev). Follows test-echo pattern which is already published correctly. CLI keeps workspace:* in dependencies because it uses pnpm publish which auto-resolves workspace protocol.
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.21.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BaseFindingCategory | (string & {})— AUDIT-E1..E4, 18/18 EARS greengitgov.agent.categoriesfield, semantic-release devDeps, fixed workspace:* → peerDeps pattern@gitgov/agent-security-auditas dependency (zero-friction install)Test plan
npm view @gitgov/agent-security-audit versionreturns published version