Repository navigation
Conversation
…exceptions when Github App on enterprise level is used
|
see also #469 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and fixes to better support GitHub Enterprise installations, enhance configuration flexibility, and increase test coverage for edge cases. The changes ensure the application can correctly handle both organization and enterprise scopes, especially in environments where both configuration values might be present. Additionally, the handling of GitHub App installations is made more robust, and related tests are expanded.
Enterprise and Organization Scope Handling:
server/sync-entry.tsto prioritize the enterprise identifier (NUXT_PUBLIC_GITHUB_ENT) when the scope is set to 'enterprise', even if an organization variable is also set, and improved error messages for missing required variables.resolveDisplayNameinshared/utils/resolveDisplayName.tsto derive the effective scope and display name based on the actual configuration, preventing mismatches between displayed scope and identifiers.tests/sync-entry.spec.tsto cover cases where both org and enterprise variables are set, and to ensure proper error handling when required variables are missing. [1] [2]tests/MainComponent.displayName.spec.tsto verify display name logic when both scope and identifiers are set.GitHub App Installation Handling:
server/modules/github-app-auth.tsto support installations with enterprise accounts that usesluginstead oflogin, and to ignore installations lacking a valid identifier. [1] [2] [3] [4]server/utils/sync-auth.tsto safely handle installations without aloginfield.tests/github-app-auth.spec.tsandtests/sync-auth.spec.tsto cover installations with only aslugand to ensure installations without an account login are ignored. [1] [2]Configuration and Environment Variables:
docker-compose.ymlto provide more flexible and consistent environment variable defaults for organization/enterprise scope, GitHub App credentials, and billing variables. [1] [2]Dependency Management:
brace-expansionoverride frompackage.json.