feat: request full commit data from pr list - #109
Merged
Conversation
plozanol
added
type: feat
sdomingobasora
approved these changes
Dec 18, 2022
sdomingobasora
added
status: done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As @manerow noted on WhatsApp, the lines added and deleted from a commit didn't come in the JSON when you retrieve the PR commit list. It seems that is needed to retrieve every commit individually by its SHA code, and get the additions and deletions from the stats section.
This PR is blocked by #108, because it needs its code to compile.