Skip to content

fix: remove JsonProperty from User entity - #119

Merged
mikededo merged 5 commits into
mainfrom
fix/remove-json-property-from-user
Dec 21, 2022
Merged

fix: remove JsonProperty from User entity#119
mikededo merged 5 commits into
mainfrom
fix/remove-json-property-from-user

Conversation

@mikededo

@mikededo mikededo commented Dec 18, 2022

Copy link
Copy Markdown
Contributor

Description

  • Created the GitHubUserDTO that allows us to parse the response from the GitHub API.
  • Added the UserMapper that allows us to service-agnostically convert the DTO to an Entity.
  • Added the UserMapper to the GitHub repository that was using it.

@mikededo
mikededo requested review from a team December 18, 2022 18:47
@mikededo mikededo self-assigned this Dec 18, 2022
@mikededo mikededo added type: bug Something isn't working status: code review PR ready to be reviewed labels Dec 18, 2022
@mikededo mikededo added this to the 2 - MVP milestone Dec 18, 2022
@mikededo
mikededo marked this pull request as ready for review December 18, 2022 18:48
@mikededo
mikededo merged commit 1987b5c into main Dec 21, 2022
@mikededo
mikededo deleted the fix/remove-json-property-from-user branch December 21, 2022 15:06
@sdomingobasora sdomingobasora added status: done PR/Issue completed and removed status: code review PR ready to be reviewed labels Dec 21, 2022
@mikededo mikededo linked an issue Dec 22, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: done PR/Issue completed type: bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: remove JsonProperty from User

3 participants