feat: command configuration - #34
Merged
Merged
Conversation
sdomingobasora
added
type: feat
mikededo
suggested changes
Nov 29, 2022
mikededo
suggested changes
Nov 29, 2022
mikededo
left a comment
mikededo
left a comment
Contributor
There was a problem hiding this comment.
I wanted to add this changes in the previous review...
mikededo
force-pushed
the
feat/command-configuration
branch
from
November 29, 2022 17:22
36aa9f2 to
814293c
Compare
mikededo
force-pushed
the
feat/command-configuration
branch
from
November 29, 2022 17:29
3170fa8 to
814293c
Compare
mikededo
approved these changes
Nov 29, 2022
mikededo
approved these changes
Nov 30, 2022
mikededo
added
status: done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #33
I have modified the commands to acommodate the observations made in the cited issue, and I have created some classes that will validate the inputs from the user, as per Github conventions (in the case of names) and our date requirements (i.e. that the user cannot request data for the current month).
Some very simple tests were also added. Request any changes you'd like.