Small object Ids refactor and extract external repository use cases - #64
Merged
manerow merged 6 commits intoDec 9, 2022
Merged
Conversation
added 5 commits
December 9, 2022 19:41
manerow
added
type: bug
Contributor
|
I think the base branch is not the correct, as we would also merge the changes from the #63 pull request. |
Collaborator
Author
True! I've mistaken the destination branch, i'll change it inmediately |
mikededo
suggested changes
Dec 9, 2022
|
|
||
| public class FetchTeamsFromOrganization { | ||
| private TeamExternalRepository teamRESTRepository; | ||
| private final TeamExternalRepository teamRESTRepository; |
Contributor
There was a problem hiding this comment.
Hmm, I forgot to rename this variables. Could you do it? Rename the teamRESTRepository for teamExternalRepository.
Contributor
|
Also, by seeing the test results, I see that the code is failing. I think there's been an issue somewhere. I will help on fixing this. |
Contributor
Fixed ✅ |
mikededo
added
status: done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've refactored the application entities IDs changing from Long to Integer as it is an standard from the GitHub API and i found we'll work more smoothly having the same types as they provide on the responses. Also, i've deleted the autoincrement feature from the primary keys of the database tables as we should work with the provided GitHub API Ids.
Since my changes were affecting all the common database initial schema i've opted to refactor the initial db changelog file and re-create the database. It's currently working correctly on this branch.
Also, i've been working on creating an specific usecase for fetching all the repositories from a team and another use case for fetching the users from a team. They both call the corresponding external repositories.