Skip to content

fix: fetch with name over id - #69

Merged
mikededo merged 3 commits into
feat/user_option_controllerfrom
fix/fetch-with-name-over-id
Dec 10, 2022
Merged

fix: fetch with name over id#69
mikededo merged 3 commits into
feat/user_option_controllerfrom
fix/fetch-with-name-over-id

Conversation

@mikededo

@mikededo mikededo commented Dec 10, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

  • Fixed the issue with the http calls that was using ids instead of names.
  • Found also other issues with the refactor and https urls.

Closes #67

@mikededo mikededo self-assigned this Dec 10, 2022
@mikededo
mikededo changed the base branch from main to feat/user_option_controller December 10, 2022 17:11
@mikededo
mikededo requested a review from a team December 10, 2022 17:12
@mikededo mikededo added type: bug Something isn't working status: done PR/Issue completed labels Dec 10, 2022
@mikededo mikededo added this to the 2 - MVP milestone Dec 10, 2022
@mikededo mikededo linked an issue Dec 10, 2022 that may be closed by this pull request
bug: fix refactor issue of fetching data using ids #67
Closed
@mikededo
mikededo merged commit 4e7e17e into feat/user_option_controller Dec 10, 2022
@mikededo
mikededo deleted the fix/fetch-with-name-over-id branch December 10, 2022 17:13
@mikededo mikededo changed the title fix/fetch with name over id fix: fetch with name over id Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manerow manerow manerow approved these changes

Assignees

@mikededo mikededo

Labels

status: done PR/Issue completed type: bug Something isn't working

Projects

None yet

Milestone

2 - MVP

Development

Successfully merging this pull request may close these issues.

bug: fix refactor issue of fetching data using ids

2 participants

@mikededo @manerow