Skip to content

Exclude checks that don't always run from the sync script - #4264

Merged
henrymercer merged 1 commit into
mainfrom
henrymercer/exclude-pr-only-checks-from-sync-checks
Oct 23, 2026
Merged

henrymercer merged 1 commit into
mainfrom
henrymercer/exclude-pr-only-checks-from-sync-checks

Conversation

@henrymercer

Copy link
Copy Markdown
Contributor

Exclude github-advanced-security and License compliance check from the checks that pr-checks/sync-checks.ts makes required. These checks don't run on every PR, so requiring them would block the PRs they don't run on.

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Which use cases does this change impact?

Environments:

  • Testing/None - This change does not impact any CodeQL workflows in production.

How did/will you validate this change?

  • Other - Before this change, a dry run of pr-checks/sync-checks.ts --ref f033e23010ed0ec7f126990ec8c7182da9978c38 proposed adding both checks to main, releases/v3 and releases/v4. With this change, the dry run excludes them and proposes no changes.

If something goes wrong after this change is released, what are the mitigation and rollback strategies?

  • Development/testing only - This change cannot cause any failures in production.

How will you know if something goes wrong after this change is released?

  • Other

Are there any special considerations for merging or releasing this change?

  • No special considerations - This change can be merged at any time.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI max review requested due to automatic review settings October 23, 2026 10:43
@github-actions github-actions Bot added the size/XS Should be very easy to review label Oct 23, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused configuration change uses the existing exact-match exclusion mechanism and matches the stated purpose.

No open issues 🎉

What changed in this PR

Prevents required-check synchronization from blocking PRs by requiring checks that do not run on every PR.

Changes:

  • Adds exact-name exclusions for github-advanced-security and License compliance check.
  • Documents why these checks should not be made required.
File Description
pr-checks/​excluded.yml Excludes both conditional checks from required-check synchronization.

Review effort: Max

@henrymercer
henrymercer marked this pull request as ready for review October 23, 2026 10:52
@henrymercer
henrymercer requested a review from a team as a code owner October 23, 2026 10:52
@henrymercer
henrymercer added this pull request to the merge queue Oct 23, 2026
Merged via the queue into main with commit 562acf5 Oct 23, 2026
229 checks passed
@henrymercer
henrymercer deleted the henrymercer/exclude-pr-only-checks-from-sync-checks branch October 23, 2026 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Should be very easy to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants