Repository navigation
Remove stale credential filtering TODO - #1790
Merged
jeffwidman merged 1 commit intoSep 29, 2026
Merged
Conversation
jeffwidman
force-pushed
the
jeffwidman/document-prefiltered-registry-credentials
branch
from
September 25, 2026 17:50
dceeb6b to
41f4243
Compare
jeffwidman
changed the title
jeffwidman
marked this pull request as ready for review
September 29, 2026 06:52
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The comment-only change matches the stated purpose and introduces no behavioral risk.
Review effort: Balanced
Findings: None
What changed in this PR
Removes a stale TODO from credential handling without changing runtime behavior.
Changes:
- Deleted the obsolete credential-filtering TODO.
| File | Description |
|---|---|
src/main.ts |
Removes the stale comment from credentialsFromEnv. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
jurre
approved these changes
Sep 29, 2026
jeffwidman
enabled auto-merge (squash)
September 29, 2026 07:12
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jeffwidman
force-pushed
the
jeffwidman/document-prefiltered-registry-credentials
branch
from
September 29, 2026 07:13
41f4243 to
ab8b53c
Compare
jeffwidman
deleted the
jeffwidman/document-prefiltered-registry-credentials
branch
September 29, 2026 07:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TODO suggests that this Action should filter private registry credentials. That filtering belongs in internal credential-provisioning systems, before credentials are passed to the Action, so the TODO is not actionable in this repository.
This PR removes the misleading TODO. It does not change runtime behavior.