Repository navigation
probe - #3794
Closed
shhhhhhjokerist wants to merge 1 commit into
Closed
probe#3794shhhhhhjokerist wants to merge 1 commit into
shhhhhhjokerist wants to merge 1 commit into
Conversation
`ServerRequest.ProtocolVersion()` returns the version the client asked for during `initialize`, not the version the server answered. The initialize handshake always negotiates down to 2025-11-25, and unknown version strings such as `zzz` compared lexically as newer than 2026-07-28. Both cases listed protocol-gated tools that the session cannot actually use. Derive the version from the per-request `_meta` value when it is present, which is authoritative for the 2026-07-28 protocol. Otherwise cap the session value to the newest version the initialize handshake can negotiate (2025-11-25) and compare against the known protocol versions instead of comparing strings lexically. Fixes github#3763
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.