Conversation
Now keep track of origin of wavefront (e.g. did it come from file? igram?) Also keep track if wavefront was manually inverted by user
|
🚀 New build available for commit |
atsju
approved these changes
Dec 22, 2025
atsju
left a comment
atsju
left a comment
Collaborator
There was a problem hiding this comment.
If I understand the intent correctly, I think it's a good first step.
There will still be the popup when loading igrams.
Collaborator
Author
exactly. |
increase readability slightly and eliminate potential global label conflicts.
Collaborator
Author
|
I did your suggestion @atsju. |
|
🚀 New build available for commit |
atsju
approved these changes
Dec 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm probably not done with autoinvert but this should improve it a lot!
I added 2 member variables to class wavefront:
The second one keeps track if a user inverted this wavefront. The first keeps track of where this wavefront came from:
enum WavefrontOrigin {wfUnknown, wfIgram, wfFile, wfSimulation, wfAverage, wfSubtraction, wfDemo, wfZernikes, wfSmoothed};If the wavefront didn't come from an igram or if it was manually inverted then the auto-invert procedure is bypassed. The wavefront origin flag may be useful for other things some day. Not sure.
I tested this very thoroughly. For example when you do "test stand astig removal tool" the various created wavefronts have the flag for file, average, etc. Rotated wavefronts copy the origin of the wavefront before rotation.