Skip to content

fix some compile warnings and bitwise operators#311

Merged
atsju merged 3 commits into
averageProfilefrom
JST/averageProfileFixes
Jan 1, 2026
Merged

fix some compile warnings and bitwise operators#311
atsju merged 3 commits into
averageProfilefrom
JST/averageProfileFixes

Conversation

@atsju

@atsju atsju commented Dec 31, 2025

Copy link
Copy Markdown
Collaborator

I'm not pushing to Dales branch directly so this PR is to add changes to averageProfile branch

@atsju atsju requested review from githubdoe and gr5 December 31, 2025 11:15
@atsju atsju force-pushed the JST/averageProfileFixes branch from 140e89f to e1dbc17 Compare December 31, 2025 11:23
@atsju atsju marked this pull request as ready for review December 31, 2025 11:25
@github-actions

Copy link
Copy Markdown

🚀 New build available for commit 807ca77
Download installer here

@github-actions

Copy link
Copy Markdown

🚀 New build available for commit 140e89f
Download installer here

@github-actions

Copy link
Copy Markdown

🚀 New build available for commit e1dbc17
Download installer here

@gr5

gr5 commented Dec 31, 2025

Copy link
Copy Markdown
Collaborator

It never occurred to me you could do a PR for a branch other than the main branch! Cool.

@gr5

gr5 commented Dec 31, 2025

Copy link
Copy Markdown
Collaborator

I just looked at the changes. They look fine. But Dale and I are still discussing the auto-invert feature. I think we are getting close. Of course we could take out his changes to that auto-invert dialog if we want to speed up a new release but I think it can wait a bit longer.

Also Dale created some enums that may (or might not!) get reverted.

@atsju

atsju commented Jan 1, 2026

Copy link
Copy Markdown
Collaborator Author

I just looked at the changes. They look fine. But Dale and I are still discussing the auto-invert feature. I think we are getting close. Of course we could take out his changes to that auto-invert dialog if we want to speed up a new release but I think it can wait a bit longer.

Also Dale created some enums that may (or might not!) get reverted.

I possible I would recommend doing it in a different pull request. I will merge this as Dale approved it then we can hopefully finish the other PR soon.

@github-actions

github-actions Bot commented Jan 1, 2026

Copy link
Copy Markdown

🚀 New build available for commit cb82a26
Download installer here

@atsju atsju merged commit ed69f2b into averageProfile Jan 1, 2026
13 of 14 checks passed
@atsju atsju deleted the JST/averageProfileFixes branch January 1, 2026 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants