feat: add admin picker when editing .mega_cedar.json#2147
Conversation
Migrate callisto to dense codegen, keep polymorphic joins in entity_ext, bump russh and remove lazy_static/ed25519-dalek, and normalize webhook event enum labels to underscores with Enum rs_type call-site fixes.
Let Cedar admins select org members in BlobEditor and regenerate entity-store JSON via POST /api/v1/admin/cedar/generate before commit.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f5bfa70d5b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| <MegaCedarAdminPicker | ||
| fileContent={fileContent} | ||
| onContentGenerated={handleCedarContentGenerated} | ||
| disabled={updateBlobMutation.isPending} |
There was a problem hiding this comment.
When an admin has already made a change, toggling another checkbox starts generateCedar.mutateAsync but the parent editor still only disables saving for updateBlobMutation.isPending. On a slow or failed generation, the user can open the commit dialog and save the previous .mega_cedar.json content while the picker UI already reflects the newer selection, so the committed admin list can miss the last toggle. Please lift the generation pending state to the editor or otherwise disable commit/save until the latest generation completes.
Useful? React with 👍 / 👎.
2 participants
No description provided.