feat: update selkies web client build process and add no-sidebar diagnosis documentation - #46
Conversation
…nosis documentation
|
| Filename | Overview |
|---|---|
| .devcontainer/skills/codespace-webtop/scripts/selkies-native.sh | Builds and deploys the dashboard correctly in the success case, but fails to propagate build or copy errors and can report installation success with an unusable web root. |
| .devcontainer/skills/codespace-webtop/references/web-client-no-sidebar.md | Adds a focused diagnosis and recovery procedure explaining the distinction between bare web-core and the standalone dashboard. |
| .devcontainer/skills/codespace-webtop/templates/autostart.bashrc | Corrects the brace-group syntax by adding the required semicolon before the closing brace. |
| .devcontainer/skills/codespace-webtop/SKILL.md | Updates installation, troubleshooting, and build-order documentation to describe the dashboard-based web client. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart LR
A[Clone Selkies repository] --> B[Install and build web-core]
B --> C[Dashboard prebuild copies selkies-core.js]
C --> D[Build dashboard]
D --> E[Replace web_root with dashboard dist]
E --> F[Selkies serves dashboard through nginx]
Prompt To Fix All With AI
### Issue 1
.devcontainer/skills/codespace-webtop/scripts/selkies-native.sh:264-265
**Addon build failures are ignored**
When dependency installation or either addon build fails, `cmd_build_web` continues, can clear `web_root`, and can return success from the final `ls`; `cmd_install` then creates the installed marker and reports completion even though Selkies has an empty, stale, or incompatible frontend.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Reviews (1): Last reviewed commit: "feat: update selkies web client build pr..." | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| build_addon "$web_core_dir" | ||
| build_addon "$dashboard_dir" |
There was a problem hiding this comment.
When dependency installation or either addon build fails, cmd_build_web continues, can clear web_root, and can return success from the final ls; cmd_install then creates the installed marker and reports completion even though Selkies has an empty, stale, or incompatible frontend.
Prompt To Fix With AI
This is a comment left during a code review.
Path: .devcontainer/skills/codespace-webtop/scripts/selkies-native.sh
Line: 264-265
Comment:
**Addon build failures are ignored**
When dependency installation or either addon build fails, `cmd_build_web` continues, can clear `web_root`, and can return success from the final `ls`; `cmd_install` then creates the installed marker and reports completion even though Selkies has an empty, stale, or incompatible frontend.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
2 participants
This pull request addresses the most common failure mode in the Selkies webtop skill: serving the wrong web client (bare
selkies-web-coreinstead of the fullselkies-dashboardUI). It updates the documentation, scripts, and templates to ensure the correct build and deployment of the web client, improves error-proofing for autostart shell hooks, and adds a reference guide for diagnosing missing sidebar issues.Web client build and deployment fixes:
cmd_build_webfunction inselkies-native.shnow clones the full Selkies repo, builds bothselkies-web-core(first) andselkies-dashboard, and serves the dashboard'sdist/as the web root. This guarantees the sidebar UI is present and prevents the common "no sidebar" bug.SKILL.mdis updated to emphasize that the web client must beselkies-dashboard, notselkies-web-core, and details the correct build order and troubleshooting steps. [1] [2]Autostart shell hook robustness:
autostart.bashrc) and script generator now correctly terminates the command group with a semicolon before the closing brace, preventing syntax errors in.bashrcand ensuring reliable startup. [1] [2]Troubleshooting and reference documentation:
web-client-no-sidebar.md, provides a detailed diagnosis and fix recipe for the "no sidebar" issue, including how to confirm which client is served and how to build and verify the correct dashboard UI.