Conversation
…h older Python versions
Contributor
There was a problem hiding this comment.
Pull request overview
Updates UTC timestamp generation in MnemonMemoryProvider to use timezone.utc instead of datetime.UTC, keeping stored index timestamps timezone-aware while improving compatibility with Python environments that may not expose datetime.UTC.
Changes:
- Import
timezonefromdatetime. - Replace
datetime.now(datetime.UTC)withdatetime.now(timezone.utc)when writing"ts"in the local ID index.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+23
to
+24
| from datetime import datetime | ||
| from datetime import timezone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a minor update to the way UTC timestamps are generated in
mnemon/__init__.py. The change replaces the use ofdatetime.UTCwith the correcttimezone.utcfor creating timezone-aware timestamps. This ensures compatibility with the standard library and avoids potential errors.timezone.utcinstead of the incorrectdatetime.UTCinmnemon/__init__.py. [1] [2]…h older Python versions