Conversation
…whitelisting options
There was a problem hiding this comment.
Pull request overview
This PR rebrands the VS Code extension from “Hermes AI Agent” to “Hermes Code Agent” and enhances the tool permission workflow by adding a configurable approval mode plus persistent tool whitelisting to reduce repeated prompts.
Changes:
- Renamed extension metadata (name, display name, description, activity bar title) and bumped version.
- Added a tool approval gating mechanism driven by
~/.hermes/config.yamland introduced “Always Allow” to persist tool approvals in workspace state. - Updated lockfile metadata to reflect the new package name/version.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/extension.ts | Adds approval mode reading + persistent tool whitelisting in the permission request handler. |
| package.json | Updates extension branding fields and increments version. |
| package-lock.json | Updates lockfile package name/version to match the rebranded extension. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Comment on lines
274
to
285
| const allowOptionId = optionIdByIntent(params, 'allow'); | ||
| const denyOptionId = optionIdByIntent(params, 'deny'); | ||
| const allow = 'Allow Once'; | ||
| const deny = 'Deny'; | ||
| const always = 'Always Allow'; | ||
| const choice = await vscode.window.showWarningMessage( | ||
| summarizePermissionRequest(params), | ||
| { modal: true }, | ||
| allow, | ||
| deny, | ||
| allow, | ||
| always, | ||
| ); |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…expression' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…ests The 'Always Allow' button now checks if the tool identifier is the fallback 'an action' (indicating a malformed permission request). If it is, the action is approved for this request only, but not persisted to the whitelist. This prevents a situation where a user could accidentally whitelist all future malformed/unknown permission requests by clicking 'Always Allow' once. Addresses review comment on PR #16 at discussion_r3296018150
Comment on lines
291
to
+295
| const allowOptionId = optionIdByIntent(params, 'allow'); | ||
| const denyOptionId = optionIdByIntent(params, 'deny'); | ||
| const allow = 'Allow Once'; | ||
| const deny = 'Deny'; | ||
| const always = 'Always Allow'; |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Comment on lines
304
to
308
| const choice = await vscode.window.showWarningMessage( | ||
| summarizePermissionRequest(params), | ||
| { modal: true }, | ||
| allow, | ||
| deny, | ||
| ...buttons, | ||
| ); |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the branding and enhances the tool approval workflow for the VS Code extension. The most significant changes include renaming the extension from "Hermes AI Agent" to "Hermes Code Agent" and introducing a safer, more flexible tool permission system that supports persistent whitelisting and a new approval mode.
Branding Updates:
package.jsonfrom "hermes-ai-agent" to "hermes-code-agent", updated the display name, description, and version number, and changed the activity bar title to "Hermes Code Agent". [1] [2]package.jsonto reflect the new branding ("hermes agent" instead of "hermes").Tool Approval and Security Improvements:
~/.hermes/config.yaml, to determine if explicit tool approval is required; defaults to safe mode if the config is missing or unparseable.