Update docker-publish.yml to fix mnemon ci test + pi-agent failback plugin - #45
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
There was a problem hiding this comment.
🟡 Changes recommended
The added --new flag appears unsupported for the pinned Hermes version and risks breaking the CI smoke test by causing the command to fail.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates the Docker publish GitHub Actions workflow’s Mnemon integration smoke test to invoke Hermes chat with a --new flag.
Changes:
- Modify the workflow’s “Hermes remembers” test command to run
hermes chat --new -q ...instead ofhermes chat -q ....
File summaries
| File | Description |
|---|---|
| .github/workflows/docker-publish.yml | Adjusts the Hermes CLI invocation used during the Mnemon integration test in CI. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| timeout 60 docker exec -u abc "$CONTAINER_NAME" \ | ||
| hermes chat -q "my name is $TEST_NAME, remember this in mnemon" \ | ||
| hermes chat --new -q "my name is $TEST_NAME, remember this in mnemon" \ |
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
…ll fallback extension
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
gitricko
changed the title
This pull request introduces several updates to the Docker build, configuration, and integration test setup for the project. The main focus is on improving model provider failover, updating dependencies, and refining integration test logic. Below are the most important changes grouped by theme:
Model Provider Failover & Configuration:
docker/pi-models.jsonconfiguration to fully define bothomnirouteandmodelrelayproviders, including detailed model specs, fallback chains, and API keys set to"no-key-needed"for local use. This enables robust failover between providers.docker/pi-settings.jsonto specify apackagesarray that installs thepi-failoverextension from a GitHub repository, supporting the new failover logic.docker/start-pi.shto automatically install thepi-failoverextension during startup, ensuring the failover mechanism is always available.Dependency Updates:
modelrelayto version1.22.1in thedocker/Dockerfileand switched to direct versioned installation via npm instead of installing from a GitHub fork, ensuring compatibility and stability. [1] [2]Integration Test Improvements:
.github/workflows/docker-publish.yml) by adding a delay (sleep 120) before running the Mnemon integration test to ensure services are ready.hermesCLI for retrieval checks instead ofclaude, and commented out the oldclaude-based logic for clarity and future reference. Output and error messages were updated to reflect this change.This pull request updates the Mnemon integration test step in the.github/workflows/docker-publish.ymlworkflow. The main changes are to improve test reliability and switch the retrieval test from using theclaudecommand to thehermescommand.Test reliability improvements:
sleep 120command before running the Mnemon integration test to allow services to fully start up, reducing the chance of race conditions.Test logic and tool changes: