Update versions in Dockerfile - #47
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The changes are limited to straightforward Docker ARG version bumps with no functional logic modifications.
Pull request overview
Updates pinned component versions in the Docker build to pull newer upstream releases.
Changes:
- Bump
OMNIROUTE_VERSIONfrom3.8.49to3.8.50 - Bump
OLLAMA_VERSIONfrom0.33.2to0.33.3 - Bump
PI_VERSIONfrom0.84.4to0.85.1andMNEMON_VERSIONfrom0.2.7to0.2.8
File summaries
| File | Description |
|---|---|
| docker/Dockerfile | Updates build ARG version pins for several bundled components. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
| Filename | Overview |
|---|---|
| .github/workflows/docker-publish.yml | Moves workflow permissions, adds per-ref concurrency cancellation, and restores Claude-based Mnemon retrieval. |
| docker/Dockerfile | Updates the pinned versions of OmniRoute, Ollama, Pi, and Mnemon. |
| docker/start-hermes.sh | Extends the Hermes dashboard readiness polling window from one minute to ten minutes. |
| docker/start-omniroute.sh | Updates readiness probing and combo creation for OmniRoute 3.8.50 while disabling automatic MCP setup. |
Reviews (4): Last reviewed commit: "Update Docker publish workflow with conc..." | Re-trigger Greptile
Increased the maximum attempts for waiting for OmniRoute to be ready from 120 to 180. Updated the health check URL and modified the combo creation command to include model specifications.
Added concurrency settings to cancel in-progress runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the Docker build and startup scripts to improve reliability, update dependencies, and streamline the CI workflow. The most significant changes include updating several dependency versions, increasing timeouts and health checks for better startup robustness, and adjusting the GitHub Actions workflow for better concurrency and test accuracy.
Dependency Updates:
OMNIROUTE_VERSIONto3.8.50,OLLAMA_VERSIONto0.33.3,PI_VERSIONto0.85.1, andMNEMON_VERSIONto0.2.8indocker/Dockerfilefor the latest features and fixes.CI/CD Workflow Improvements:
permissionsblock, added aconcurrencygroup to cancel in-progress runs for the same branch/PR, and improved test output and logic in.github/workflows/docker-publish.yml. [1] [2] [3] [4]Startup Robustness:
docker/start-hermes.shto handle slower startups./healthzindocker/start-omniroute.sh.These changes collectively improve system reliability, keep dependencies up to date, and streamline the CI pipeline.