Repository navigation
fix(selection): no other app's text action in Compose's toolbar either - #45
Merged
Merged
Conversation
3.1.1 turned the text classifier off ("Translate" sent a note online),
and the body's native field already keeps editing entries only
(MenuDuChampDuCorps). Compose's fields (title, search, vault) did not:
Compose foundation 1.12 (ProcessText_android) adds to their selection
toolbar every VISIBLE app that declares an ACTION_PROCESS_TEXT action,
and any app may, under any name. Removing the <queries> for it (audit of
2026-09-26) is not enough: before Android 11 there is no package
visibility, every app is listed (minSdk is 24); from 11 on, visibility
is granted per whole app, and any app another <queries> reaches comes
with all its text actions.
sansActionsDeTexteDesAutresApps() sets
ComposeFoundationFlags.isSmartSelectionEnabled to false before the first
composition, on every version: Compose's toolbars keep editing only, as
the body does. Lost: reading aloud from the toolbar (TalkBack's action),
still reachable through its own accessibility shortcut. Measured with a
probe app that declares a PROCESS_TEXT action, see the pull request.
Test on the real activity: the flag is off once MainActivity has run.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
gitubpatrice
added a commit
that referenced
this pull request
Oct 31, 2026
…elds too - version.properties: 3.2.2, base versionCode 505 (APKs 5051-5053). - Changelogs in the five languages, READMEs and SECURITY (EN/FR): the selection toolbar fix (#45). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
3.1.1 turned the text classifier off, and the note body's native field already keeps editing entries only. Compose's fields (title, search, vault) still listed other apps' text actions (
ACTION_PROCESS_TEXT) in their selection toolbar: Compose 1.12 adds every visible app that declares one, any app, under any name.Removing the
<queries>for it (audit of 2026-09-26) is not enough: there is no package visibility before Android 11 (minSdk 24), and from 11 on it is granted per whole app.Change:
sansActionsDeTexteDesAutresApps()setsComposeFoundationFlags.isSmartSelectionEnabled = falsebefore the first composition, on every version — Compose's toolbars keep editing only, as the body does. Lost: reading aloud from the toolbar (still reachable through its own accessibility shortcut).Measured on the other apps of the portfolio (same Compose, API 34 emulator): a probe app declaring a
PROCESS_TEXTaction is listed by a Compose toolbar that can see it (SMS Tech before its fix); TalkBack's "Lecture à voix haute", listed by every Compose toolbar, is gone once the flag is off (Read Files Tech). Not measured on Notes itself. Test:SansClassificationDeTexteTest5/5 on the emulator. Gate green (assembleDebug assembleDebugAndroidTest testDebugUnitTest lintDebug detekt ktlintCheck).🤖 Generated with Claude Code