feat: LessThan operator implementation#13
Open
raizo07 wants to merge 3 commits into
Open
Conversation
raphaelDkhn
reviewed
Apr 23, 2025
Contributor
There was a problem hiding this comment.
@raizo07 Do the tests pass on your side? The tests fail on GH and on my side. There's a problem with the constraints
raphaelDkhn
reviewed
Apr 23, 2025
| /// - result is 1 if self < other, 0 otherwise | ||
| /// - remainder is always 0 (to maintain consistency with other operations that return remainders) | ||
| #[inline] | ||
| pub fn lt(&self, other: &Self) -> (Self, Self) { |
Contributor
There was a problem hiding this comment.
The remainder is unnecessary here. We don't need to return a tuple.
| #[inline] | ||
| pub fn lt(&self, other: &Self) -> (Self, Self) { | ||
| if self.0 < other.0 { | ||
| (Self(1), Self(0)) // True case: self < other |
Contributor
There was a problem hiding this comment.
I think it should return the fixed-point representation of 1, instead of 1 directly. Otherwise, the result is unscaled.
Author
|
@raphaelDkhn will implement the necessary changes and re-run the test again |
Author
@raphaelDkhn I'm currently getting this error for the second test 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
LessThan operator implementation for fixed point
Does this introduce a breaking change?
Other information