This repository was archived by the owner on Mar 3, 2025. It is now read-only.
[WIP] Bs feature branch#557
Open
bshmu wants to merge 16 commits into
Open
Conversation
raphaelDkhn
reviewed
Jan 31, 2024
Collaborator
raphaelDkhn
left a comment
There was a problem hiding this comment.
Hi @bshmu, thanks for your PR!
Some things are missing to make the PR valid.
Please follow this step-by-step tutorial, to see how to implement operators in Orion:
https://orion.gizatech.xyz/academy/tutorials/implement-new-operators-in-orion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Adds a directory within operators to hold all MutMatrix related logic.
MutMatrix is updated with to_tensor() and from_tensor() methods to call tensor objects methods on the MutMatrix object. Some tensor methods (e.g. reshape, transpose, matmul, reduce_sum) are added to MutMatrix implementation.
Two new traits/impls for MutMatrix are added:
Tests are added and all imports using MutMatrix (e.g. TreeEnsembleClassifier) are updated accordingly.
Does this introduce a breaking change?