Skip to content
This repository was archived by the owner on Mar 3, 2025. It is now read-only.

feat: global maxpool operator#584

Open
RajeshRk18 wants to merge 7 commits into
gizatechxyz:developfrom
RajeshRk18:feat-global_maxpool
Open

feat: global maxpool operator#584
RajeshRk18 wants to merge 7 commits into
gizatechxyz:developfrom
RajeshRk18:feat-global_maxpool

Conversation

@RajeshRk18
Copy link
Copy Markdown

@RajeshRk18 RajeshRk18 commented Feb 23, 2024

Implemented Global Maxpool operator.
Resolves #275

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information

@raphaelDkhn
Copy link
Copy Markdown
Collaborator

Hi @RajeshRk18, the tests failed. Please make sure they pass on your end

@RajeshRk18
Copy link
Copy Markdown
Author

RajeshRk18 commented Mar 4, 2024

Hi @RajeshRk18, the tests failed. Please make sure they pass on your end

Yeah, looking into it. I don't know why I get this error. Can you help me with this?
IMG_20240304_203916_826.png

@raphaelDkhn raphaelDkhn changed the base branch from main to develop March 5, 2024 15:22
@raphaelDkhn
Copy link
Copy Markdown
Collaborator

Hi @RajeshRk18, the tests failed. Please make sure they pass on your end

Yeah, looking into it. I don't know why I get this error. Can you help me with this? IMG_20240304_203916_826.png

Please try these:

  • Which version of scarb do you have?
  • Can you try to do scarb clean and then scarb test to see if it helps.
  • Can you try to run tests without --workspace flag

@RajeshRk18
Copy link
Copy Markdown
Author

I'm using scarb 2.5.4.
scarb clean and scarb test didn't help
I ran without workspace flag. Still the same error

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feat: GlobalMaxPool

2 participants