fix(css): change font-size from pixel to rem#154
Open
spaceone wants to merge 3 commits into
Open
Conversation
perl -pe 's/font-size:\s*(\d+)px/font-size: @{[$1\/16]}rem/g' -i $(git grep -l "font-size: .*px")
tehron
requested changes
May 30, 2026
tehron
left a comment
tehron
left a comment
Collaborator
There was a problem hiding this comment.
I have to admit, I don't really agree with this PR: :/
- I think there should be no more px units left (judging from the title)
- There shouldn't be a need for
1.0625rems or so, just make it a little smaller or bigger, no biggy IMHO - The "fix(css): remove font-size: 98%;" should undo everything I did, incl. tweaking styles of GeSHI in some file I forget the name for.
- Unsure about the effect of the chore-changes
- I'd be very helpful to have some screenshots before/after the changes attached
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.