Skip to content

Position map consistency check #1091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Maxwell-Rosen wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Position map consistency check #1091

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
41e94ad
Root cause found and fixed. Your diagnosis was right that only maximu…
Maxwell-Rosen Jul 31, 2026
0bb9588
Shorten comment
Maxwell-Rosen Aug 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 14 additions & 12 deletions gyrokinetic/zero/gkyl_position_map_priv.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -672,11 +672,13 @@ position_map_constB_z_numeric(double t, const double *xn, double *fout, void *ct

if (enable_limits_min_B || enable_limits_max_B)
{
// Set a minimum cell size on the edges
// Assume that at inflection points, Theta = theta. This should be true
// Set a minimum cell size on the edges.
double Theta_left = interval_lower;
double Theta_right = interval_upper;
double theta_middle = 0.5 * (interval_lower + interval_upper);
double dB_this_region = fabs(gpm->constB_ctx->bmag_extrema[region+1] - gpm->constB_ctx->bmag_extrema[region]);
double theta_bound_lower = theta_lo + (dB_global_lower / dB_cell) * theta_dxi;
double theta_bound_upper = theta_lo + ((dB_global_lower + dB_this_region) / dB_cell) * theta_dxi;
double theta_middle = 0.5 * (theta_bound_lower + theta_bound_upper);

bool left_is_maximum = gpm->constB_ctx->min_or_max[region];
bool right_is_maximum = gpm->constB_ctx->min_or_max[region+1];
Expand All @@ -695,29 +697,29 @@ position_map_constB_z_numeric(double t, const double *xn, double *fout, void *ct

double right_straight_line_value, left_straight_line_value;
if (left_is_maximum){
left_straight_line_value = max_slope_max_B * theta + (1-max_slope_max_B) * Theta_left;
left_straight_line_value = Theta_left + max_slope_max_B * (theta - theta_bound_lower);
}
else {
left_straight_line_value = max_slope_min_B * theta + (1-max_slope_min_B) * Theta_left;
left_straight_line_value = Theta_left + max_slope_min_B * (theta - theta_bound_lower);
}

if (right_is_maximum){
right_straight_line_value = max_slope_max_B * theta + (1-max_slope_max_B) * Theta_right;
right_straight_line_value = Theta_right + max_slope_max_B * (theta - theta_bound_upper);
}
else {
right_straight_line_value = max_slope_min_B * theta + (1-max_slope_min_B) * Theta_right;
right_straight_line_value = Theta_right + max_slope_min_B * (theta - theta_bound_upper);
}

if ( fout[0] < right_straight_line_value &&
((right_is_maximum && enable_limits_max_B) ||
((!right_is_maximum) && enable_limits_min_B)))
if ( fout[0] < right_straight_line_value &&
((right_is_maximum && enable_limits_max_B) ||
((!right_is_maximum) && enable_limits_min_B)))
{
fout[0] = right_straight_line_value;
}

if (fout[0] > left_straight_line_value &&
if (fout[0] > left_straight_line_value &&
((left_is_maximum && enable_limits_max_B) ||
((!left_is_maximum) && enable_limits_min_B)))
((!left_is_maximum) && enable_limits_min_B)))
{
fout[0] = left_straight_line_value;
}
Expand Down
Loading