Cleaning up regression and unit tests plus valgrind - #1117
Closed
Maxwell-Rosen wants to merge 34 commits into
Closed
Cleaning up regression and unit tests plus valgrind#1117Maxwell-Rosen wants to merge 34 commits into
Maxwell-Rosen wants to merge 34 commits into
Conversation
… with every build
…ry to bring these back at some point, but I can't use failing unit tests
… to runregression
Restore regtests
…ks out main to generate accepted results).
Update Mac machine file to test Jenkins
Retain all 20 fork commits and prefer the fork's versions for overlapping changes while integrating current upstream main and agent_tools-jenkins. Preserve the fork's regression settings, test selections, timing tools, and fixes. Adapt geometry metadata names and interpolation variables to the combined code. Keep upstream's removal of the rescale_ghost_jacf test because its supporting API has been removed. No additional testing requested.
Collaborator
|
this undoes changes I made recently so that multiblock 1x tests run. please fix |
Collaborator
Author
|
I fixed the changes with the multiblock tests |
…ts the resolution of a bunch of GK regression resolutions, but these are good cuts
This was referenced Sep 9, 2026
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a collection of the changes I made when working at Preference Model to clean up the regression testing and unit testing inside Gkeyll. Several changes focus on reducing the resolution of regression tests to make them more manageable.
Valgrind-sanitized unit tests.
Added several AI-generated unit tests to improve our coverage
Removing all writes from unit tests
Ensuring every regression test outputs only 1 frame
Loosened some tolerances so unit tests would pass
Improvements to runregression:
Sorting by cost