Gk sheath bc with mu dependent vcut - #95
Open
Antoinehoff wants to merge 43 commits into
Open
Conversation
…associated headers.
…ernels, add_apar and add_apardot kernels. We conserve the electrostatic part of the scripts.
…ity of generating separated EM/ES kernels. This will be cleaned once the design in Gkeyll is fully decided.
…lock instance. This did not change a iota of the output kernels but better be safe than sorry. There is an error in the addapardot volume kernel I think because my first tests explode when I include it, will work on that tomorrow 🤓 have a good night folks 😘
…nd Apardot on bP instead of bC.
…or electromagnetic routines.
…d correct a few typos in comments
…s much as possible the precomputed geometric quantities like normcurlbhat_quad for surface flux and bioverJB_list for the volume computation. A comment in each script is added to point out the terms responsible to oscillations observed in the 3x2v Alfven testcase. The volume term builds an oscillation in n_e along y at longer time whereas the surface flux term creates a discontinuity in n_e along y at the first frame of the regression test. It is still unknown if these terms are the source of the 3x2v alfven issue or if they are triggered unphysically from other part of the code like the Helmholtz solver.
manauref
requested changes
May 14, 2026
Collaborator
Author
|
thanks @manauref for your review! I think I've addressed everything, only a small question if |
manauref
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is related to these Gkeyll PR and DR