Refactor gk-rz into the naming conventions which are used by GK and G… - #233
Open
Maxwell-Rosen wants to merge 1 commit into
Open
Refactor gk-rz into the naming conventions which are used by GK and G…#233Maxwell-Rosen wants to merge 1 commit into
Maxwell-Rosen wants to merge 1 commit into
Conversation
…K specific, and refactor out the core methods of interpolating on geometry into map.py in operations. Explicit geometry construction is kept general, but the GK-specific nature is kept in diagnostics. Examples are updated. CLI names are still gk_rz. Script pg.gk.rz() is a short hand for chaining a few core commands together, including constructing the geometry object and the projection. Entire-Checkpoint: 01M26HA71FS8K7HRX1BNFMXXQ5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor gk-rz into the naming conventions used by GK and GK-specific, and refactor the core methods for interpolating on geometry into map.py in operations. Explicit geometry construction is kept general, but the GK-specific nature is kept in diagnostics. Examples are updated. CLI names are still gk_rz. Script pg.gk.rz() is a shorthand for chaining a few core commands together, including constructing the geometry object and the projection.
Entire-Checkpoint: 01M26HA71FS8K7HRX1BNFMXXQ5
https://entire.io/gh/gkeyllorg/postgkyl/session/01a08cf8-4ccc-7701-83ee-677c67e51e31