Skip to content

Pcc3 api fixes - #48

Merged
nvasta merged 20 commits into
v2from
pcc3-api-fixes
Jul 3, 2026
Merged

Pcc3 api fixes#48
nvasta merged 20 commits into
v2from
pcc3-api-fixes

Conversation

@nvasta

@nvasta nvasta commented Jul 3, 2026

Copy link
Copy Markdown
Member

This pull request extends the original one made for the PCC3 API Fixes:

This just speeds things up, implementing the changes requested. Overall this branch brings:

  • Minor fixes in the exception handling of the search-service and retrieve-results interfaces.
  • Complete removal of the EnvelopeSignatureReference field.
  • The introduction of a new enum for the service status, instead of the generic text field.
  • Addition of the retrieve-results interface in the automated signature checking procedure (filter for JAX-RX, Advice for Springboot).

jakob22r and others added 20 commits June 19, 2026 14:42
@jakob22r
RetrieveResult request should be intersepted by SECOM Filter
21a001e
@jakob22r
Proper exception handling of SecomSignatureVerificationExceptions thr…
488e0e3 
…own when the request type is a RetrieveResultObj
@jakob22r
Remove references to envelopeSignatureReference in Envelope models an…
22e3075 
…d interface is is agreed for CD3
@jakob22r
RetrieveResultInterface can throw an unathorized exception for the ca…
fc2bb3c 
…se in which the information consumer is not allowed to pull on the given transactionId. It is a responsibility of the serviceRegistry to conduct such check.
@jakob22r
Endpointtype is optional and therefore nullable according to openAPI …
b69e609 
…spec
@jakob22r
Proper mapping from SECOm exceptions to correct error codes
7ddd717
@jakob22r
Handling undhandled exception that may occur during parsing such that…
557ddd4 
… a bad request is reported to the client rather than internal server error
@jakob22r
Properly map a NotFound e.g. from JAX-RS to a NotFoundException. Rele…
57414ee 
…vant when calling a secom controller incorrectly, we'd want to return 404 and not a 400 as was the case
@jakob22r
Service Status is now an enum according to updated openAPI
5875dab
@jakob22r
Proper routing of retrieveResult secom exceptions
6904634
@jakob22r
Update test to use ServiceInstanceStatusEnum
299f81e
@jakob22r
Simplify enum
dedc361
@jakob22r
Throw secom type exception rather than generic illegalArgExcep
731659f
@jakob22r
ServiceInstanceObject uses correct Enum type for serviceInstanceStatus
f054770
@jakob22r
ServiceInstanceStatus uses proper enum in tests
f496801
@jakob22r
Implement secom enum inteface
7b254cd
@jakob22r
Get rid of all remiscents of envelopeSignatureRef
de465e7
Nikolaos Vastardis Nikolaos Vastardis
Fixing the pull request based on the comments provided
341684f
Nikolaos Vastardis Nikolaos Vastardis
Also harmonizing the search service and retrieve results exception ha…
a940efb 
…ndling
Nikolaos Vastardis Nikolaos Vastardis
Also harmonizing the SearchParameters isEmpty function definitions
20c11ef
nvasta
nvasta commented Jul 3, 2026
View reviewed changes

@nvasta nvasta left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me now.

@nvasta
nvasta merged commit 7dc9db3 into v2 Jul 3, 2026
1 check passed
@nvasta
nvasta deleted the pcc3-api-fixes branch July 3, 2026 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nvasta @jakob22r