Fix WireGuard plugin reliability - #6
Merged
Merged
Conversation
glafeara
marked this pull request as ready for review
August 2, 2026 12:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Several subprocess and lifecycle boundaries did not propagate failure reliably. In particular, process-substitution export failures could look successful, import interruption could cross the old/new profile commit boundary, and the UI could acknowledge work that its busy guards had rejected. Secret-bearing QR and editor files also lacked complete crash cleanup.
Impact
Exports no longer produce partial successful output, replacement imports preserve a recoverable profile state, terminal recovery cases do not trigger unsafe editor retries, and IPC callers receive accurate acceptance results. Runtime state and temporary key material are restricted to a validated owner-only directory.
Validation
bash tests/run.sh— 59 passedbash -n backend.sh tests/*.sh tests/fake/*omarchy plugin validate .git diff --checkqmllint NamePrompt.qml QrWindow.qml RenameWindow.qml Service.qml